Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: resource attribute is added in the exception #2491

Merged
merged 17 commits into from
Mar 29, 2023
Merged

feat: resource attribute is added in the exception #2491

merged 17 commits into from
Mar 29, 2023

Conversation

palashgdev
Copy link
Contributor

@palashgdev palashgdev commented Mar 23, 2023 •
edited
Loading

part of #2483

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the enhancement New feature or request label Mar 23, 2023
@palashgdev palashgdev self-assigned this Mar 23, 2023
@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@palashgdev palashgdev marked this pull request as draft March 23, 2023 17:43
@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@makeavish makeavish linked an issue Mar 24, 2023 that may be closed by this pull request
FE: Add environment filtering to exceptions #2485
Closed
@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@srikanthccv srikanthccv added this to the v0.18.0 milestone Mar 24, 2023
@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@palashgdev palashgdev marked this pull request as ready for review March 24, 2023 15:22
@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

2 similar comments
@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@palashgdev palashgdev mentioned this pull request Mar 26, 2023
Merged
@srikanthccv
Copy link
Member

https://www.loom.com/share/d1dd30116ce848eba1a293ff4109c93a

@srikanthccv
Copy link
Member

srikanthccv commented Mar 27, 2023 •
edited
Loading

Why is the tag key for the same attribute different on pages?
Screenshot 2023-03-27 at 4 34 53 PM
Screenshot 2023-03-27 at 4 35 45 PM

This key filtering doesn't work since the keys won't match, and I don't think the collector is adding the _ or resource prefix.

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

makeavish
makeavish previously approved these changes Mar 27, 2023
View reviewed changes
@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@srikanthccv srikanthccv mentioned this pull request Mar 28, 2023
Merged
@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@sonarcloud
Copy link

sonarcloud bot commented Mar 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@makeavish makeavish merged commit 99ed314 into develop Mar 29, 2023
@makeavish makeavish deleted the 2483 branch March 29, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makeavish makeavish makeavish approved these changes

Assignees

@palashgdev palashgdev

Labels
codeball:needs-careful-review Codeball enhancement New feature or request frontend
Projects
None yet
Milestone
v0.18.0
Development

Successfully merging this pull request may close these issues.

FE: Add environment filtering to exceptions
3 participants
@palashgdev @srikanthccv @makeavish