Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: org name is fixed #2810

Merged
merged 2 commits into from
Jun 5, 2023
Merged

fix: org name is fixed #2810

merged 2 commits into from
Jun 5, 2023

Conversation

palashgdev
Copy link
Contributor

@palashgdev palashgdev commented Jun 2, 2023 •
edited by prashant-shahi
Loading

Fixes #2820

@palashgdev palashgdev requested a review from makeavish June 2, 2023 07:16
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@request-info
Copy link

request-info bot commented Jun 2, 2023

We would appreciate it if you could provide us with more info about this issue/pr!

@github-actions github-actions bot added the bug Something isn't working label Jun 2, 2023
@makeavish makeavish linked an issue Jun 5, 2023 that may be closed by this pull request
Org name missing and unable to signup using invite link #2820
Closed
makeavish
makeavish approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@makeavish makeavish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Can be merged after @prashant-shahi approves

prashant-shahi
prashant-shahi approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@prashant-shahi prashant-shahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I see that multiple API calls are happening for updating both user and org meta.
We could improve on that in another PR after internal discussion.

image

@prashant-shahi prashant-shahi merged commit e73432d into develop Jun 5, 2023
@prashant-shahi prashant-shahi deleted the fix/org-name-signup branch June 5, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashant-shahi prashant-shahi prashant-shahi approved these changes

@makeavish makeavish makeavish approved these changes

Assignees
No one assigned
Labels
bug Something isn't working request-more-info
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Org name missing and unable to signup using invite link
3 participants
@palashgdev @makeavish @prashant-shahi