-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(FE): variables with multiple values are merged into one string #2960
fix(FE): variables with multiple values are merged into one string #2960
Conversation
Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗 |
@Bergiu can you please check the tsc error though it is breaking |
frontend/src/container/NewDashboard/DashboardVariablesSelection/VariableItem.tsx
Outdated
Show resolved
Hide resolved
Is the Select component from ant or from rc-select? It's imported from 'antd' but the error message looks like it's using the Select component from rc-select. If it's from rc-select the function could be: const getSelectValue = (): string | string[] => {
if (Array.isArray(variableData.selectedValue)) {
return variableData.selectedValue.map((item) => item.toString());
}
return variableData.selectedValue?.toString() || '';
}; |
Well, for the two failing checks, I don't know what I need to do. |
You don't need to worry about them. |
Is there any problem left or is the issue ready to be merged? |
Sorry we haven't had a chance to review/test this. Will get back to you on this soon. |
I tested this. This seems to have fixed the original issue. I will be testing it for other types, such as queries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Thanks for approving, but the merge is still blocked because of the update to the main branch. Could you merge it directly after the update branch+approve? |
frontend/src/container/NewDashboard/DashboardVariablesSelection/VariableItem.tsx
Outdated
Show resolved
Hide resolved
@Bergiu small changes after LGTM :-D to merge |
@palashgdev please take a look |
thanks @Bergiu for the PR :-D |
Fixes #2526