Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the table view for the traces explorer #2964

Merged
merged 25 commits into from
Jul 18, 2023

Conversation

dnazarenkoo
Copy link
Contributor

Close: 2336

@CLAassistant
Copy link

CLAassistant commented Jun 22, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
4 out of 5 committers have signed the CLA.

✅ yeshev
✅ dnazarenkoo
✅ palashgdev
✅ makeavish
❌ Nazarenko19
You have signed the CLA already but the status is still pending? Let us recheck it.

@dnazarenkoo dnazarenkoo marked this pull request as ready for review June 22, 2023 14:28
@dnazarenkoo dnazarenkoo force-pushed the feat/traces-explorer-table-view branch 6 times, most recently from 78336ce to 8361753 Compare June 26, 2023 09:28
@makeavish makeavish self-requested a review June 27, 2023 13:56
@makeavish
Copy link
Member

In case of table view it has been decided that we will fix aggregate interval to global time interval.
@dnazarenkoo Please update this

@makeavish
Copy link
Member

Legend format breaks in table view
Screenshot 2023-06-27 at 19 28 13

@makeavish
Copy link
Member

Aggregate operator along with aggregate attribute should be show in table column name.
Example: In below screenshot, Avg column name should be replaced by Avg - durationNano
Screenshot 2023-06-27 at 19 43 44

@makeavish
Copy link
Member

Formula broken in table view:
Screenshot 2023-06-27 at 19 58 45

Copy link
Member

@makeavish makeavish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the reported issues

@dnazarenkoo dnazarenkoo force-pushed the feat/traces-explorer-table-view branch from 8361753 to df59072 Compare June 28, 2023 10:18
makeavish
makeavish previously approved these changes Jul 18, 2023
@palashgdev palashgdev merged commit 07833b9 into SigNoz:develop Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table view tab for in traces explorer
6 participants