Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix initial columns for the list view / fix attributes API call #3056

Merged
merged 8 commits into from
Jul 7, 2023

Conversation

dnazarenkoo
Copy link
Contributor

@dnazarenkoo dnazarenkoo commented Jul 6, 2023

Close:

@request-info
Copy link

request-info bot commented Jul 6, 2023

We would appreciate it if you could provide us with more info about this issue/pr!

makeavish
makeavish previously approved these changes Jul 6, 2023
@dnazarenkoo dnazarenkoo changed the title fix: fix initial columns for the list view fix: fix initial columns for the list view / fix attributes API call Jul 6, 2023
@makeavish
Copy link
Member

I see multiple API calls to fetch attributes for initial columns. I think it unnecessary.
As we discussed please avoid relationship between aggregate API and initial columns.
Screenshot 2023-07-07 at 07 35 50

@ankitnayan ankitnayan merged commit 857e505 into SigNoz:develop Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants