Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add the ability to drag columns #3100

Merged
merged 20 commits into from
Jul 18, 2023
Merged

feat: add the ability to drag columns #3100

merged 20 commits into from
Jul 18, 2023

Conversation

dnazarenkoo
Copy link
Contributor

@dnazarenkoo dnazarenkoo commented Jul 11, 2023 •
edited
Loading

Close: #3080

@request-info
Copy link

request-info bot commented Jul 11, 2023

We would appreciate it if you could provide us with more info about this issue/pr!

@makeavish
Copy link
Member

I am not able to drag columns in list view of logs.
@dnazarenkoo

@dnazarenkoo
Copy link
Contributor Author

I am not able to drag columns in list view of logs. @dnazarenkoo

@makeavish yes, because I didn't add that logic to the logs explorer as the ticket was only labeled traces explorer, but don't worry, I'll add that logic to the logs as well

makeavish
makeavish requested changes Jul 12, 2023
View reviewed changes
Copy link
Member

@makeavish makeavish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug in adding/removing a column in logs list view
https://www.loom.com/share/a1eeb52ac2c241dc8d448538390d0fb6?sid=da3c9671-05d1-4bdf-8a95-bfb6fb1021b8

@dnazarenkoo
Copy link
Contributor Author

dnazarenkoo commented Jul 16, 2023 •
edited
Loading

Bug in adding/removing a column in logs list view https://www.loom.com/share/a1eeb52ac2c241dc8d448538390d0fb6?sid=da3c9671-05d1-4bdf-8a95-bfb6fb1021b8

@makeavish updated
cc: @palashgdev

makeavish
makeavish previously approved these changes Jul 18, 2023
View reviewed changes
palashgdev
palashgdev suggested changes Jul 18, 2023
View reviewed changes
frontend/src/components/ResizeTable/ResizeTable.tsx Outdated Show resolved Hide resolved
frontend/src/components/ResizeTable/ResizeTable.tsx Outdated Show resolved Hide resolved
frontend/src/components/ResizeTable/styles.ts Outdated Show resolved Hide resolved
frontend/src/hooks/useDragColumns/index.ts Outdated Show resolved Hide resolved
frontend/src/hooks/useDragColumns/index.ts Outdated Show resolved Hide resolved
frontend/src/container/LogsExplorerList/index.tsx Outdated Show resolved Hide resolved
@palashgdev
Copy link
Contributor

@dnazarenkoo can you please look as above looks small cosmetic changes

@palashgdev palashgdev self-requested a review July 18, 2023 11:39
@palashgdev palashgdev merged commit 8f1451e into SigNoz:develop Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palashgdev palashgdev palashgdev approved these changes

@makeavish makeavish makeavish left review comments

Assignees
No one assigned
Labels
request-more-info
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to change column position in list view
3 participants
@dnazarenkoo @makeavish @palashgdev