Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add suggestion to order by filter #3162

Merged
merged 9 commits into from
Jul 19, 2023
Merged

feat: add suggestion to order by filter #3162

merged 9 commits into from
Jul 19, 2023

Conversation

yeshev
Copy link
Contributor

@yeshev yeshev commented Jul 17, 2023

Close #3073

@yeshev yeshev self-assigned this Jul 17, 2023
@yeshev yeshev requested a review from palashgdev as a code owner July 17, 2023 14:57
@github-actions github-actions bot added the enhancement New feature or request label Jul 17, 2023
palashgdev
palashgdev previously approved these changes Jul 18, 2023
View reviewed changes
@makeavish
Copy link
Member

Even when I search for service I am getting timestamp in suggestion.

Screenshot 2023-07-18 at 18 28 42

@makeavish
Copy link
Member

makeavish commented Jul 18, 2023 •
edited
Loading

Don't show #SIGNOZ_VALUE to user, rather just show count() or count('aggregate key selected by user')

Screenshot 2023-07-18 at 18 32 42

Also below issue is caused by above issue

Screenshot 2023-07-18 at 18 34 22

@yeshev
Copy link
Contributor Author

yeshev commented Jul 18, 2023

Even when I search for service I am getting timestamp in suggestion.

Screenshot 2023-07-18 at 18 28 42

Fixed

@yeshev
Copy link
Contributor Author

yeshev commented Jul 18, 2023

Don't show #SIGNOZ_VALUE to user, rather just show count() or count('aggregate key selected by user')

Screenshot 2023-07-18 at 18 32 42 Also below issue is caused by above issue Screenshot 2023-07-18 at 18 34 22

Fixed

nityanandagohain
nityanandagohain reviewed Jul 19, 2023
View reviewed changes
Copy link
Member

@nityanandagohain nityanandagohain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions work in list view but not in table and timeseries view? @makeavish is it someting we decided on or it's being missed?

@makeavish
Copy link
Member

Suggestions work in list view but not in table and timeseries view? @makeavish is it someting we decided on or it's being missed?

Suggestions in table or ts view doesn't have any usecase. User would only want to sort by value or attributes he sees. (groupBy attributes)

@nityanandagohain
Copy link
Member

@makeavish we made some decisions in the last dicsussion with Ankit and Srikanth if you remember #3088 (comment)

@nityanandagohain
Copy link
Member

NVM it's should show up if it's there in group by

@palashgdev palashgdev merged commit 98a2ef4 into develop Jul 19, 2023
@palashgdev palashgdev deleted the feat/custom_order_by_suggestions branch July 19, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palashgdev palashgdev palashgdev approved these changes

@nityanandagohain nityanandagohain nityanandagohain approved these changes

@makeavish makeavish makeavish approved these changes

Assignees

@yeshev yeshev

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable Order by suggestion in traces and logs list page
4 participants
@yeshev @makeavish @nityanandagohain @palashgdev