USE_SPAN_METRICS for latency graph on Feature flag #3172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srikanthccv
reviewed
Jul 19, 2023
There was a problem hiding this comment.
Two important things.
- operations should be dynamic based on the top level opeartions API. It is hard-coded to single value. I am not sure if you did it for debugging or misunderstood the requirement. Let me know if you have any questions. Take a look the request rate to see how to do it.
- and they should be part of filter items in both traces (with different name as mentioned below) and metrics for latency graph.
It will be good to go when these two points are addressed. Thanks.
frontend/src/container/MetricsApplication/MetricsPageQueries/MetricsPageQueriesFactory.ts
Show resolved
Hide resolved
frontend/src/container/MetricsApplication/MetricsPageQueries/OverviewQueries.ts
Outdated
Show resolved
Hide resolved
frontend/src/container/MetricsApplication/MetricsPageQueries/OverviewQueries.ts
Outdated
Show resolved
Hide resolved
frontend/src/container/MetricsApplication/MetricsPageQueries/OverviewQueries.ts
Outdated
Show resolved
Hide resolved
frontend/src/container/MetricsApplication/MetricsPageQueries/OverviewQueries.ts
Outdated
Show resolved
Hide resolved
palashgdev
reviewed
Jul 19, 2023
frontend/src/container/MetricsApplication/MetricsPageQueries/MetricsPageQueriesFactory.ts
Outdated
Show resolved
Hide resolved
added 2 commits
July 19, 2023 08:03
srikanthccv
reviewed
Jul 19, 2023
palashgdev
reviewed
Jul 20, 2023
palashgdev
reviewed
Jul 20, 2023
frontend/src/container/MetricsApplication/Tabs/Overview/ServiceOverview.tsx
Outdated
Show resolved
Hide resolved
palashgdev
reviewed
Jul 20, 2023
palashgdev
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link: #1793