feat: add support for apdex settings #3186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1477
https://en.wikipedia.org/wiki/Apdex
The default apdex threshold for a service is 500ms, and users can (and ideally should) update the threshold with the appropriate value for the service. They can optionally specify a comma-separated string of status codes to ignore when deciding the error calls. This adds support for persisting and retrieving the settings.
We use the bucket boundaries when this score is calculated from metrics since we don't have raw samples. For example, if the threshold is 500ms, the boundaries used are
le=500andle=2000. See this https://stagingapp.signoz.io/dashboard/4254c4e1-3a5f-4d82-a1cc-a5c084abcb6a for example. The/api/v1/metric_metais added for thesignoz_latency_bucketmeta. This endpoint provides the metric temporality and bucket boundaries. The temporality is important because the final formula for delta and metrics differ.