Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : Hide limit param in list view of traces #3173 #3187

Merged
merged 16 commits into from
Jul 31, 2023
Merged

fix : Hide limit param in list view of traces #3173 #3187

merged 16 commits into from
Jul 31, 2023

Conversation

vasukapil
Copy link
Contributor

As the list view was also taking default value,I had created another condition for list view in switch case so that Limit is removed for list.Attached Screenshot is the updated scenario.

Screenshot 2023-07-21 at 6 54 20 PM

@welcome
Copy link

welcome bot commented Jul 21, 2023

Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗

@CLAassistant
Copy link

CLAassistant commented Jul 21, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@vasukapil
Copy link
Contributor Author

I was asked to remove the LIMIT text as well so in this commit that is also done.
Only ORDER BY, HAVING, AGGREGATION INTERVAL will be seen.screenshot attached

Screenshot 2023-07-22 at 11 36 02 AM Screenshot 2023-07-22 at 11 36 11 AM

@palashgdev @makeavish

@makeavish
Copy link
Member

@vasukapil Limit operator in logs is required, this PR removes that as well.
Please update

@vasukapil
Copy link
Contributor Author

@vasukapil Limit operator in logs is required, this PR removes that as well. Please update

okay looking into it.

@vasukapil
Copy link
Contributor Author

PR updated as per the suggested changes @makeavish

makeavish
makeavish previously approved these changes Jul 26, 2023
View reviewed changes
@palashgdev
Copy link
Contributor

@vasukapil can you please resolve the conflicts

@vasukapil
Copy link
Contributor Author

@vasukapil can you please resolve the conflicts

@palashgdev conflicts are resolved

palashgdev
palashgdev previously approved these changes Jul 31, 2023
View reviewed changes
@palashgdev
Copy link
Contributor

@vasukapil can you check build pipeline is breaking

@vasukapil
Copy link
Contributor Author

@vasukapil can you check build pipeline is breaking

yes checking

@vasukapil
Copy link
Contributor Author

@palashgdev It is resolved now.

@palashgdev
Copy link
Contributor

can you please check @makeavish

@makeavish makeavish merged commit 4397c53 into SigNoz:develop Jul 31, 2023
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palashgdev palashgdev palashgdev approved these changes

@makeavish makeavish makeavish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vasukapil @CLAassistant @makeavish @palashgdev