Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: column name with legend #3200

Merged
merged 11 commits into from
Jul 28, 2023
Merged

fix: column name with legend #3200

merged 11 commits into from
Jul 28, 2023

Conversation

yeshev
Copy link
Contributor

@yeshev yeshev commented Jul 26, 2023 •
edited
Loading

Close #3199

@yeshev yeshev self-assigned this Jul 26, 2023
@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label Jul 26, 2023
@request-info
Copy link

request-info bot commented Jul 26, 2023

We would appreciate it if you could provide us with more info about this issue/pr!

@palashgdev palashgdev mentioned this pull request Jul 26, 2023
Merged
@palashgdev palashgdev marked this pull request as ready for review July 28, 2023 07:19
@palashgdev palashgdev self-requested a review as a code owner July 28, 2023 07:19
@srikanthccv
Copy link
Member

  1. When there are multiple queries, one column shows the same number repeatedly, although the returned data from API is different. For example, P99(durationNanoe) with the group by serviceName, rate with the group by serviceName. This is true for any additional column.
Screenshot 2023-07-28 at 2 12 54 PM
  1. When there are queries with different group by, the table data is not correct. The sum_rate(system_cpu_time) should have a value in the last row and P99 duration should not exist.
Screenshot 2023-07-28 at 2 15 09 PM

@yeshev yeshev requested a review from srikanthccv as a code owner July 28, 2023 15:28
srikanthccv
srikanthccv reviewed Jul 28, 2023
View reviewed changes
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you both

@palashgdev palashgdev merged commit 5469cd3 into develop Jul 28, 2023
7 of 9 checks passed
@palashgdev palashgdev deleted the fix/table_columns branch July 28, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palashgdev palashgdev palashgdev approved these changes

@srikanthccv srikanthccv srikanthccv approved these changes

Assignees

@yeshev yeshev

Labels
bug Something isn't working request-more-info
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Table View enhancement
3 participants
@yeshev @srikanthccv @palashgdev