Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: usage exporter logic updated #3211

Merged
merged 5 commits into from
Aug 1, 2023
Merged

feat: usage exporter logic updated #3211

merged 5 commits into from
Aug 1, 2023

Conversation

nityanandagohain
Copy link
Member

@nityanandagohain nityanandagohain commented Jul 27, 2023 •
edited
Loading

Fixes https://github.com/SigNoz/engineering-pod/issues/1005

  • Use cron instead of interval and upload at 00:00
  • Upload usage when starting up QS
  • Upload usage before shutdown of QS

@github-actions github-actions bot added the enhancement New feature or request label Jul 27, 2023
@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@nityanandagohain nityanandagohain marked this pull request as ready for review July 27, 2023 09:19
@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@srikanthccv
Copy link
Member

My familiarity with this code is virtually nil; I can still take a look at it but consider the review of someone who knows it better.

@nityanandagohain
Copy link
Member Author

@ankitnayan should we merge it ?

@ankitnayan ankitnayan merged commit 348fa0b into develop Aug 1, 2023
7 of 8 checks passed
@ankitnayan ankitnayan deleted the issue_1005 branch August 1, 2023 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitnayan ankitnayan ankitnayan approved these changes

@srikanthccv srikanthccv Awaiting requested review from srikanthccv

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nityanandagohain @srikanthccv @ankitnayan