fix: lowercase filter operator and increase default conn settings #3310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srikanthccv
requested review from
ankitnayan,
nityanandagohain and
makeavish
and removed request for
nityanandagohain
|
I believe logs operator is already taken care here |
ankitnayan
approved these changes
Aug 10, 2023
|
@makeavish I'd appreciate your review. The latency chart breaks when (cloud) users use filtering 
.
|
makeavish
approved these changes
Aug 10, 2023
Wasn't aware that it was causing issues on staging. According to discussions I understood that this was not affecting users currently as it is being handled on the frontend temporarily. |
indyarocks
pushed a commit
to indyarocks/signoz
that referenced
this pull request
Aug 10, 2023
indyarocks
added a commit
to indyarocks/signoz
that referenced
this pull request
Aug 10, 2023
fix: empty filters field (SigNoz#3290) fix: lowercase filter operator and increase default conn settings (SigNoz#3310)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows configuring the ClickHouse client connection options
MaxOpenConns,MaxIdleConns, andDialTimeout. The default values from the client library do not work well when tens of alerts are configured, and when several team members in org access the UI, it is easy to have ten running connections busy and the remaining request timeout quickly.And also fixes #3210