-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support in query service for querybuilder filterset based log pipelines #3560
Merged
raj-k-singh
merged 5 commits into
develop
from
chore/qs-log-pipelines-with-qb-filterset
Sep 20, 2023
Merged
Add support in query service for querybuilder filterset based log pipelines #3560
raj-k-singh
merged 5 commits into
develop
from
chore/qs-log-pipelines-with-qb-filterset
Sep 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We would appreciate it if you could provide us with more info about this issue/pr! |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
raj-k-singh
force-pushed
the
chore/qs-log-pipelines-with-qb-filterset
branch
from
September 15, 2023 05:50
3d038bf
to
b70c5e4
Compare
srikanthccv
reviewed
Sep 15, 2023
raj-k-singh
commented
Sep 17, 2023
raj-k-singh
force-pushed
the
chore/qs-log-pipelines-with-qb-filterset
branch
from
September 17, 2023 15:01
9bdf57f
to
f06e9f6
Compare
srikanthccv
approved these changes
Sep 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that was a neat change.
raj-k-singh
force-pushed
the
chore/qs-log-pipelines-with-qb-filterset
branch
from
September 20, 2023 06:38
f06e9f6
to
34a605d
Compare
manishm
pushed a commit
to manishm/SIGFOR
that referenced
this pull request
Sep 27, 2023
…elines (SigNoz#3560) * chore: use v3.Filterset as pipeline filters in logparsing pipelines integration tests * chore: get logparsing integration tests passing with filterset based pipeline * chore: get all other breaking tests passing * chore: move models.logparsingpipeline to logparsingpipeline.model * chore: implement Valuer and Scanner interfaces for v3.FilterSet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #3506