Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support in query service for querybuilder filterset based log pipelines #3560

Merged
merged 5 commits into from
Sep 20, 2023

Conversation

raj-k-singh
Copy link
Collaborator

@raj-k-singh raj-k-singh commented Sep 15, 2023

Contributes to #3506

@request-info
Copy link

request-info bot commented Sep 15, 2023

We would appreciate it if you could provide us with more info about this issue/pr!

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@raj-k-singh raj-k-singh marked this pull request as ready for review September 15, 2023 05:00
@raj-k-singh raj-k-singh force-pushed the chore/qs-log-pipelines-with-qb-filterset branch from 3d038bf to b70c5e4 Compare September 15, 2023 05:50
@raj-k-singh raj-k-singh force-pushed the chore/qs-log-pipelines-with-qb-filterset branch from 9bdf57f to f06e9f6 Compare September 17, 2023 15:01
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that was a neat change.

@raj-k-singh raj-k-singh force-pushed the chore/qs-log-pipelines-with-qb-filterset branch from f06e9f6 to 34a605d Compare September 20, 2023 06:38
@raj-k-singh raj-k-singh merged commit 3db8a25 into develop Sep 20, 2023
8 of 9 checks passed
@raj-k-singh raj-k-singh deleted the chore/qs-log-pipelines-with-qb-filterset branch September 20, 2023 07:09
manishm pushed a commit to manishm/SIGFOR that referenced this pull request Sep 27, 2023
…elines (SigNoz#3560)

* chore: use v3.Filterset as pipeline filters in logparsing pipelines integration tests

* chore: get logparsing integration tests passing with filterset based pipeline

* chore: get all other breaking tests passing

* chore: move models.logparsingpipeline to logparsingpipeline.model

* chore: implement Valuer and Scanner interfaces for v3.FilterSet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants