Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update query service telemetry #3735

Merged
merged 6 commits into from
Oct 17, 2023

Conversation

makeavish
Copy link
Member

And add new distination for saas telemetry

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the chore label Oct 12, 2023
@ankitnayan
Copy link
Collaborator

Since we are removing /api/v2/metrics/query_range altogether rather than adding /api/v3/query_range, we would be losing analytics for those.

@ankitnayan
Copy link
Collaborator

Since IdentifyUser is not called on query-service restarts, the SetUserEmail and SetCompanyDomain won't be called there. SetCompanyDomain was hence called separately at InitializeOrgpreferences at

telemetry.GetInstance().SetCompanyDomain(users[countUsers-1].Email)

So, restart of the query-service will cause no events to be sent any further due to check at https://github.com/SigNoz/signoz/pull/3735/files#diff-8a30fc5d1386f1d6463d9edd9b054e6396e8544640566ff7f3174d4058127d83R377

@makeavish
Copy link
Member Author

Since we are removing /api/v2/metrics/query_range altogether rather than adding /api/v3/query_range, we would be losing analytics for those.

No we are not using /api/v2/metrics/query_range in SigNoz at all so we won't be losing any analytics.

@ankitnayan
Copy link
Collaborator

ankitnayan commented Oct 16, 2023

This causes metrics datasource to change to active. You should check for empty filters in the payload?
#3753

@ankitnayan
Copy link
Collaborator

trying to create an empty panel makes it active metrics which is incorrect. You should check if metric_name is present or not for it to be marked as active in metrics

@makeavish
Copy link
Member Author

trying to create an empty panel makes it active metrics which is incorrect. You should check if metric_name is present or not for it to be marked as active in metrics

Updated.

@ankitnayan ankitnayan merged commit f8d3fa0 into develop Oct 17, 2023
11 checks passed
@ankitnayan ankitnayan deleted the chore/update-query-service-telemetry branch October 17, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants