Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: page break in Services overview tab #3749

Merged
merged 2 commits into from
Nov 6, 2023
Merged

fix: page break in Services overview tab #3749

merged 2 commits into from
Nov 6, 2023

Conversation

palashgdev
Copy link
Contributor

@palashgdev palashgdev commented Oct 16, 2023

close #3615
close #3442

@github-actions github-actions bot added the bug Something isn't working label Oct 16, 2023
@palashgdev palashgdev marked this pull request as ready for review November 4, 2023 18:54
@srikanthccv
Copy link
Member

This would never be null @palashgdev

type LatencyMetricMetadataResponse struct {
Delta bool `json:"delta"`
Le []float64 `json:"le"`
}

@palashgdev
Copy link
Contributor Author

palashgdev commented Nov 5, 2023

This would never be null @palashgdev

type LatencyMetricMetadataResponse struct {
Delta bool `json:"delta"`
Le []float64 `json:"le"`
}

user have reported @srikanthccv #3442 (comment)

@srikanthccv
Copy link
Member

That's correct, I had some wrong assumptions about JSON serialization https://go.dev/play/p/v4JVXhj5a-K

@srikanthccv srikanthccv changed the title fix: null check fix: page break in Services overview tab Nov 5, 2023
@palashgdev palashgdev merged commit dda0167 into develop Nov 6, 2023
13 checks passed
@palashgdev palashgdev deleted the fix/3615 branch November 6, 2023 06:46
@palashgdev palashgdev self-assigned this Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
None yet
3 participants