Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: global time range downdown for alert edit page #3751

Merged
merged 17 commits into from
Nov 1, 2023

Conversation

Rajat-Dabade
Copy link
Contributor

Close #3721

@srikanthccv
Copy link
Member

The chart currently uses the time range selected in ... during the last ... part of the Step 2 - Define Alert Conditions. With this change, it should use the global time range.

@srikanthccv
Copy link
Member

@Rajat-Dabade, let me know if my last comment was not clear. Just enabling the global time range is not enough. It should be used for the graph we show.

@srikanthccv
Copy link
Member

Discussed over a call

  • The charts should be based on the global time selection.
  • The timestamps should be part of the URL, and when a user lands on this page with a shared URL, the timestamps from URL params will be honoured.
  • The range from alert definition configuration is independent.

@Rajat-Dabade
Copy link
Contributor Author

@srikanthccv All the points mentioned above are fixed. Please review it once. Thank you.

@srikanthccv
Copy link
Member

Thanks, I will review it.

@srikanthccv
Copy link
Member

Where is the global time range filter? How do you expect the user to change the time range to see the data? The issue says we should show the time range dropdown. Or did I miss something?

Screenshot 2023-10-31 at 9 16 14 AM

@Rajat-Dabade
Copy link
Contributor Author

@srikanthccv, for me it is showing

Screenshot 2023-10-31 at 10 18 07 AM

Have to take the latest pull of the branch?

srikanthccv
srikanthccv previously approved these changes Nov 1, 2023
@Rajat-Dabade
Copy link
Contributor Author

@ankitnayan ankitnayan merged commit 092d164 into SigNoz:develop Nov 1, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show time range dropdown option in alert creation page
3 participants