Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Show pipeline preview action in more contexts #3758

Merged
merged 6 commits into from
Oct 19, 2023

Conversation

raj-k-singh
Copy link
Collaborator

@raj-k-singh raj-k-singh commented Oct 17, 2023

Contributes to #1779

Minor improvements to pipeline previews

  • use dirty pipeline state when previewing a pipeline while editing it.
  • show preview pipeline action when editing a new/unsaved pipelines
  • show preview pipeline action in viewing mode too.
  • ensure pipeline previews work even if pipeline is disabled.

Before:
more-preview-actions-before

After:
more-preview-actions-after

@raj-k-singh raj-k-singh changed the title Show pipeline preview action in more contexts chore: Show pipeline preview action in more contexts Oct 17, 2023
@github-actions github-actions bot added the chore label Oct 17, 2023
@raj-k-singh raj-k-singh marked this pull request as ready for review October 17, 2023 12:54
@raj-k-singh raj-k-singh force-pushed the chore/pipeline-preview-action-in-more-contexts branch from 858f226 to a867cdf Compare October 18, 2023 15:26
@raj-k-singh raj-k-singh force-pushed the chore/pipeline-preview-action-in-more-contexts branch from a867cdf to 455ca17 Compare October 19, 2023 04:47
@raj-k-singh raj-k-singh merged commit 53a7821 into develop Oct 19, 2023
11 checks passed
@raj-k-singh raj-k-singh deleted the chore/pipeline-preview-action-in-more-contexts branch October 19, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants