Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor[BE]: replace ioutil with io and os for file operations #3761

Merged
merged 4 commits into from
Oct 19, 2023

Conversation

swagftw
Copy link
Contributor

@swagftw swagftw commented Oct 17, 2023

solves #3748

Changes

Switched all file operations from ioutil package to io and os packages due to the deprecation of ioutil in Go 1.16.

This change contributes to the maintainability of the codebase, ensuring it's up-to-date with the current standard library. Additionally, implemented usage of filepath.Join for platform-independent file paths.

Tests

  • All test cases are passing
  • No new tests are required as no change in logic, nor the specification for ioutils has been changed in new recommended packages i.e. io and os

Deployement changes

Not applicable

Switched all file operations from ioutil package to io and os packages due to the deprecation of ioutil in Go 1.16. This change contributes to the maintainability of the codebase, ensuring it's up-to-date with the current standard library. Additionally, implemented usage of filepath.Join for platform-independent file paths.
@welcome
Copy link

welcome bot commented Oct 17, 2023

Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗

@CLAassistant
Copy link

CLAassistant commented Oct 17, 2023

CLA assistant check
All committers have signed the CLA.

@swagftw swagftw changed the title refactor: replace ioutil with io and os for file operations refactor[BE]: replace ioutil with io and os for file operations Oct 17, 2023
@swagftw
Copy link
Contributor Author

swagftw commented Oct 17, 2023

I missed to sign my commits. If that's a strict requirement, let me know the standard procedure we are following here to handle such scenarios.

@srikanthccv srikanthccv merged commit 6b2427f into SigNoz:develop Oct 19, 2023
10 of 11 checks passed
@welcome
Copy link

welcome bot commented Oct 19, 2023

Congrats on merging your first pull request!
minion-party
We here at SigNoz are proud of you! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants