fix: promql alert expr formatting for composite queries with join/unless #3784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
This fixes the issue mentioned here: https://signoz-team.slack.com/archives/C05GQNXL3FG/p1697723383400099?thread_ts=1695994015.677219&cid=C05GQNXL3FG. I would like to get it merged and deployed to them. |
ankitnayan
approved these changes
Oct 23, 2023
prashant-shahi
approved these changes
Oct 25, 2023
|
Please include this in the release along with the line chart issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For expressions such as
The current comparison isn't done against the whole query result but the right side of it which is incorrect.