[Feat]: Dynamic columns in tables #3809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 27, 2023 10:42
…ignoz into PRD-alertlist-improvement
ankitnayan
approved these changes
Oct 27, 2023
YounixM
reviewed
Oct 27, 2023
| } | ||
|
|
||
| return ( | ||
| <Typography className="DateComponent-container">{timeString}</Typography> |
|
@Rajat-Dabade: Please add screenshots. |
YounixM
reviewed
Oct 27, 2023
| className="Dropdown-button" | ||
| onClick={(e): void => e.preventDefault()} | ||
| > | ||
| <Space> |
YounixM
reviewed
Oct 27, 2023
|
|
||
| .dynamicColumnsTable-items { | ||
| display: flex; | ||
| width: 10.625rem; |
YounixM
reviewed
Oct 27, 2023
| index, | ||
| checked, | ||
| }); | ||
| setColumnsData((prevColumns) => { |
YounixM
reviewed
Oct 27, 2023
| function DateComponent( | ||
| CreatedOrUpdateTime: string | number | Date, | ||
| ): JSX.Element { | ||
| const time = new Date(CreatedOrUpdateTime); |
There was a problem hiding this comment.
handle invalid CreatedOrUpdateTime
YounixM
reviewed
Oct 27, 2023
| try { | ||
| const storedData = localStorage.getItem(tablesource); | ||
| if (typeof storedData === 'string' && dynamicColumns) { | ||
| columnVisibilityData = JSON.parse(storedData); |
There was a problem hiding this comment.
will fail if storedData is not a valid JSON.
YounixM
reviewed
Oct 27, 2023
|
|
||
| localStorage.setItem(tablesource, JSON.stringify(initialColumnVisibility)); | ||
| } catch (error) { | ||
| console.error(error); |
There was a problem hiding this comment.
Are we handling the error silently or any UI feedback is required?
YounixM
reviewed
Oct 27, 2023
| try { | ||
| const storedData = localStorage.getItem(tablesource); | ||
| if (typeof storedData === 'string' && dynamicColumns) { | ||
| const columnVisibilityData = JSON.parse(storedData); |
YounixM
reviewed
Oct 27, 2023
| import { getLabelRenderingValue } from './utils'; | ||
|
|
||
| function LabelColumn({ labels, value, color }: LabelColumnProps): JSX.Element { | ||
| const newLabels = labels.length > 3 ? labels.slice(0, 3) : labels; |
There was a problem hiding this comment.
add safety checks for labels if default initialization is not done.
YounixM
reviewed
Oct 27, 2023
| const remainingLabels = labels.length > 3 ? labels.slice(3) : []; | ||
|
|
||
| return ( | ||
| <div className="LabelColumn"> |
There was a problem hiding this comment.
className should follow camelCase /hyphenated lowercase /BEM convention
YounixM
reviewed
Oct 27, 2023
| <div> | ||
| {labels.map( | ||
| (label: string): JSX.Element => { | ||
| const tooltipTitle = |
There was a problem hiding this comment.
can be moved to a separate function for better readability.
YounixM
reviewed
Oct 27, 2023
| width: 80, | ||
| key: DynamicColumnsKey.UpdatedBy, | ||
| align: 'center', | ||
| render: (value): JSX.Element => <div>{value}</div>, |
There was a problem hiding this comment.
All values are by default rendered, render function isn't required
YounixM
reviewed
Oct 27, 2023
| dataIndex: 'createdBy', | ||
| width: 30, | ||
| key: DynamicColumnsKey.CreatedBy, | ||
| render: (value): JSX.Element => <div>{value}</div>, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3740