Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Download as CSV and Execl and Search option for key-operation table #3848

Merged
merged 16 commits into from
Nov 1, 2023

Conversation

Rajat-Dabade
Copy link
Contributor

Close: #3832
Close: #3833

@github-actions github-actions bot added the enhancement New feature or request label Oct 31, 2023
@palashgdev
Copy link
Contributor

@Rajat-Dabade this method does not take unit into account please fix this one

example:
Screenshot 2023-10-31 at 3 48 55 PM

@palashgdev
Copy link
Contributor

palashgdev commented Oct 31, 2023

ideally this downloading of csv should be handled from the backend itself taking the account of pagination in future it will be hard for the user/ client to aggregate the data

@ankitnayan
Copy link
Collaborator

ideally this downloading of csv should be handled from the backend itself taking the account of pagination in future it will be hard for the user/ client to aggregate the data

yeah..when pagination comes to play or there is huge data the search should also query the backend. But this data is not supposed to grow big so we should be good

@ankitnayan
Copy link
Collaborator

Screenshot 2023-10-31 at 9 21 53 PM

  1. Name should be the 1st column
  2. P50 should be P50 (in ms) and the same for the other P95 and P99
  3. P50 (in ms) value should be in ms. The current values are in nano.
  4. Change styling after UX consultation in a separate PR @GeekBoySupreme

@ankitnayan
Copy link
Collaborator

  • It's Error (%) and not Error Count and the value is also incorrect
  • the values of P50, P95 and P99 are duplicated and incorrect. Please verify data sanity before pushing any changes
  • append name of the service to filename? top-operations-customer.xls/csv

ankitnayan
ankitnayan previously approved these changes Nov 1, 2023
@ankitnayan
Copy link
Collaborator

@Rajat-Dabade can you also check why the numbers are treated as text in xls but as numbers in csv. We should treat them as numbers. Selecting multiple values in the column P50 should show Sum for numbers.

palashgdev
palashgdev previously approved these changes Nov 1, 2023
@YounixM YounixM merged commit 64f0ff0 into develop Nov 1, 2023
11 checks passed
@palashgdev palashgdev deleted the gh-3832 branch November 1, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants