chore: dashboards to alerts creation support in query-service #3924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We would appreciate it if you could provide us with more info about this issue/pr! |
|
Don't have much knowledge on alerts, I am probably not the best presion to review this. |
|
Honestly, nobody else has any context either and that's why I tried to add as many comments as needed to help understand the change. I will need approval to merge it so I asked both of you. |
nityanandagohain
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3912
Users will be redirected from the dashboard page to the alerts page with all the queries in a widget since there can be more than one query (for example P90, P95, P99), we ask users to select the query (it can't be multiple) that should be used against the threshold. This change add the support with
selectedQueryNamethat falls back to old logic when it doesn't exist.