Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): enable cmd+click for dashboard name in list #3947

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

joemiltonm
Copy link
Contributor

@joemiltonm joemiltonm commented Nov 10, 2023

Hi SigNoz Team,
I've added the command+click or ctrl+click to the name column in the Dashboard list. The ctrl+click was working in the Traces page, so I've made similar implementation in the dashboard page also. Below is the screencast of opening dashboards in new tab, please have a look.

Resolves #3939

Screencast.from.10-11-23.04.28.31.PM.IST.webm

Copy link
Contributor

@Rajat-Dabade Rajat-Dabade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 , awesome work @joemiltonm

@palashgdev
Copy link
Contributor

there could be another place also we where need this functionality can we plug the business logic out from this one ?

@joemiltonm
Copy link
Contributor Author

LGTM 🚀 , awesome work @joemiltonm

Thank you so much ....😊👍🏻

@YounixM YounixM merged commit d8a8430 into SigNoz:develop Nov 16, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Command+Click on dashboard name in dashbaord list to open it in a new browser tab
4 participants