Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added auth as pre-requisite for the other tests #4031

Merged
merged 4 commits into from
Nov 23, 2023
Merged

feat: added auth as pre-requisite for the other tests #4031

merged 4 commits into from
Nov 23, 2023

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented Nov 22, 2023 •
edited
Loading

  • added auth as pre-requisite for all the test cases to run
  • this saves us from login on every test suite run which saves us resources and time
  • added the navigation check across resources to check if the new release breaks any major page

@request-info Request Info
Copy link

request-info bot commented Nov 22, 2023

We would appreciate it if you could provide us with more info about this issue/pr!

@palashgdev palashgdev self-requested a review November 23, 2023 10:09
@ankitnayan ankitnayan merged commit 399d49b into SigNoz:develop Nov 23, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palashgdev palashgdev palashgdev approved these changes

@Rajat-Dabade Rajat-Dabade Rajat-Dabade approved these changes

@srikanthccv srikanthccv Awaiting requested review from srikanthccv

@ankitnayan ankitnayan Awaiting requested review from ankitnayan

Assignees
No one assigned
Labels
request-more-info
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vikrantgupta25 @Rajat-Dabade @palashgdev @ankitnayan