Fix: lettercase bug in query-builder #4120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is a working video for the above fix. please let me know if you need anything. Thank you Screen.Recording.2023-12-01.at.5.45.38.PM.mov |
palashgdev
force-pushed
the
fix/issue-4109
branch
from
38a0b40
to
a6fde9c
Compare
palashgdev
approved these changes
Dec 8, 2023
makeavish
approved these changes
Dec 19, 2023
makeavish
added a commit
that referenced
this pull request
Dec 19, 2023
This reverts commit a6b6abf.
|
This PR misses edge cases when keys has Upper case values |
|
@makeavish can you please provide example for which this is not working? |
|
Please check case when we select 
|
|
Got it. Should I raise another PR for this? or make changes in the previous one? 😕 |
Create another PR, if that works then we won't merge the revert PR #4255 |
YounixM
pushed a commit
that referenced
this pull request
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR solves the issue mentioned in #4109