fix: incorrect alert description and summary for prom rules #4190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
@ankitnayan easy one. please review. |
ankitnayan
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
I also see a similar usage at https://github.com/SigNoz/signoz/blob/develop/pkg/query-service/rules/thresholdRule.go#L782-L786
|
Yes, this is the correct usage. When the issue was originally reported we only fixed it for the builder in this PR #4047. The same issue existed in PromQL queries till now. It should be working now for all types of queries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current logic concatenates the threshold value (0.4) and target unit text (%). This is fine for units such as data (10 gbytes) and time but the percentages need conversion. The fix is to use a formatter that cares about such details.
Fixes https://github.com/SigNoz/engineering-pod/issues/1132.