Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor]: persistance of sorting and page in table #4221

Merged
merged 9 commits into from
Dec 15, 2023
Merged

[refactor]: persistance of sorting and page in table #4221

merged 9 commits into from
Dec 15, 2023

Conversation

Rajat-Dabade
Copy link
Contributor

@Rajat-Dabade Rajat-Dabade commented Dec 13, 2023 •
edited
Loading

@srikanthccv srikanthccv self-requested a review December 13, 2023 06:27
YounixM
YounixM previously approved these changes Dec 14, 2023
View reviewed changes
srikanthccv
srikanthccv approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested persistance of

  • Search text
  • Search text filter results after the poll
  • Status, alert name, severity order key
  • Pagination

@srikanthccv srikanthccv merged commit 77b4e71 into develop Dec 15, 2023
10 checks passed
@srikanthccv srikanthccv deleted the gh-4153 branch December 15, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

@YounixM YounixM YounixM approved these changes

@palashgdev palashgdev Awaiting requested review from palashgdev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Persist state using URL in the alerts page
3 participants
@Rajat-Dabade @YounixM @srikanthccv