feat: show rate limit warning in services page when total RPS > 100 #4266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YounixM
force-pushed
the
rate-limit-service-logs-message
branch
from
a125d52
to
61c5aee
Compare
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
This shouldn't be shown to everyone but only those who are on trial and haven't paid for a subscription. Also, I believe the number should be configurable from config service. We run a configs service to enable things like this without the need to build and deploy if we want to change it. What's the use of configs service if it isn't used for things like this? |
YounixM
force-pushed
the
rate-limit-service-logs-message
branch
from
61c5aee
to
e280182
Compare
|
Agreed @srikanthccv, this we wanted to push along with this release. So started off with this. |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Rajat-Dabade
approved these changes
Dec 21, 2023
makeavish
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Show rate limit warning on services page when total RPS > 100