Fix: Logs: Pipelines: add nil check for grok parser parseFrom field in generated collector config #4286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raj-k-singh
changed the title
Base automatically changed from
fix/qs-pipeline-support-membership-op-for-fields-with-dots
to
develop
December 28, 2023 05:01
raj-k-singh
force-pushed
the
fix/avoid-grok-parser-spamming-error-logs-if-field-is-missing
branch
from
39ade8d
to
89c0e6a
Compare
nityanandagohain
approved these changes
Dec 28, 2023
raj-k-singh
deleted the
fix/avoid-grok-parser-spamming-error-logs-if-field-is-missing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
collector logs get spammed if the parseFrom field specified in a grok parser doesn't exist on logs.
This change adds a nil check to the collector config generated for grok parsing processors.
Related Issues / PR's
Fixes #4182