Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show 0 as limit is user has set it to 0 #5605

Merged
merged 1 commit into from
Jul 30, 2024
Merged

fix: show 0 as limit is user has set it to 0 #5605

merged 1 commit into from
Jul 30, 2024

Conversation

YounixM
Copy link
Member

@YounixM YounixM commented Jul 30, 2024

Screenshot 2024-07-30 at 2 24 13 PM

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label Jul 30, 2024
@vikrantgupta25
Copy link
Collaborator

@YounixM let's add test cases for the same in this PR or the follow up if urgent to merge this one.

@YounixM
Copy link
Member Author

YounixM commented Jul 30, 2024

https://github.com/SigNoz/engineering-pod/issues/1592 - Added a P1 to follow on the test cases for this.

@YounixM YounixM merged commit 738d62c into develop Jul 30, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikrantgupta25 vikrantgupta25 vikrantgupta25 approved these changes

@grandwizard28 grandwizard28 grandwizard28 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YounixM @vikrantgupta25 @grandwizard28