2505 - Clear LP transport timeouts to prevent multiple connections with same CID #2599

NTaylorMullen · 2013-10-01T19:44:51Z

Before if a connection timed out its reconnecting loop and went into the disconnected state and then was instantly re-started it would cause multiple connections with the same connection id to be active; ultimately resulting in each connection booting off its counterpart.
Also added some 2.0.0 QUnit extensions so that porting changes back is easier.
Performance problem using long polling with many clients #2505

- #2335

…ens.

- Treat canceled tasks like faulted tasks. - Added another test to verify cancellation handling.

- Achieve this by recreating cursors that don't have the appropriate prefix #2061

#2061

#2498

- Test that the .NET client can receive messages over 64KB via WebSockets - Fixup the tests so they run on 1.1.x #2495

#2521

#2258 Conflicts: build/Build.proj tests/Microsoft.AspNet.SignalR.Client.CSharp.Tests/Client/ConnectionFacts.cs

#2258

- Hopefully this will avoid "SCRIPT70: Permission denied" errors in IE #2508

- Also added logging to show when a client subscribes to a hub. #2514

#2486

- Added periods to the end of every log line. - Removed "SignalR:" from beginning of logged lines so it wasn't logged twice. - Re-worded some language - Added Long poll complete log #2512

- Change the withCredentials flag to only be auto-set when cross-domain is detected (can still be explicitly set) - Conditionally do an async abort if the browser is Firefox 11+ AND withCredentials is true #2489

- This change is only needed for cross-domain scenarios - This does not work when the entire browser window is closed #2517

… to prevent our ajax communications from failing. #2511

#2511

…or receiving of messages fails #2585

…ging errors in Service Bus #2542 #2541

#2504

- Avoids timeouts being mistakenly registered as aborts - Unifies abort logic for all transports #2195 #1231 #2500

- Prevent double dispose on the client side WebSocketTransport. - Always close the websocket before cancelling the token on the server.

- Added tests that verify it noops after closing. - Made the WebSocket property internal to ensure it's not used by another other code. #2457

- Create a new cts for each websocket created.

…use the connection.url. - Also added a test to verify the fix. #2570

… server on pings will stop the connection. - This involved creating a StatusCodeConnection that will change the response status code based on a query string variable AND will respond with a specified status code. #2360

…so a MessagingException

#2509

…iframe DOM when we don't need to. - This involved adding a state check for connected and deleting the frame message count on transport stop. - Also added an iframeClearThreshold value to the forever frame transport to allow me to test it. #2494

… stress scenarios. #2494

- Added periods to the end of every log line. - Removed "SignalR:" from beginning of logged lines so it wasn't logged twice. - Re-worded some language. - Added Long poll complete log. - Made it so the clearing hub invocation log is only called if callbacks are available to be cleared. #2487

…t expire when there's lack of activity. - This also involved adding a new configuration option 'pingInterval' which can be set via milliseconds in the connection.start #2507

…ent configuration options in addition to multiple connection starts and stops. - Also modified the existing tests which called ping interval by also passing in a transport (no longer need to do that). #2507

- Also added two fields to the private data field of a connection object. #2505

…nnecting does not result in simultaneous polls attempting to connect. #2125

- Added an extra check after long polling error handler trigger to ensure that multiple connections do not occur. #2505

DamianEdwards and others added 30 commits September 10, 2013 12:27

Delete minified signalr JS client from repo

e6a5d8f

Remove generated file from repo

5ac0c8c

- #2335

Fixed new line issues with js tests.

3be799e

Don't capture the execution context when registering cancellation tok…

c1d3503

…ens.

Handle canceled tasks in the Subscription and MessageBroker.

4da11a4

- Treat canceled tasks like faulted tasks. - Added another test to verify cancellation handling.

Recreate cursors when switching between default and scaleout scenarios

9b0ce1f

- Achieve this by recreating cursors that don't have the appropriate prefix #2061

New tests for cursor prefixes

7479aaa

#2061

Use a random 4 bytes for cursor checksum for in DefaultSubscription.

daf65a0

#2498

Fixed the unit tests to use the right prefix.

4665586

Disable WebSocketHandler's max incoming message size on .NET client

393305a

- Test that the .NET client can receive messages over 64KB via WebSockets - Fixup the tests so they run on 1.1.x #2495

Added isLongRunning flag to IHttpClient interface.

6dda782

Use unique connection groups in .NET 4 client per IHttpClient instance

7aea6ad

#2521

Only set connection group on desktop.

848b6a3

Fixed unobserved task on the server with websockets.

a031b81

Bump version to 1.1.5

73ac99b

Delete another minified SignalR JS client from the repo

02ce890

Added files to the new project made changes to Build.proj

a3f1bf4

#2258 Conflicts: build/Build.proj tests/Microsoft.AspNet.SignalR.Client.CSharp.Tests/Client/ConnectionFacts.cs

Moved files to appropriate test projects

e2a9dab

#2258

Stop using jQuery for managing the iframe in the foreverFrame transport

ea88f3d

- Hopefully this will avoid "SCRIPT70: Permission denied" errors in IE #2508

Removed test that creates 50,000 XHRs

104b43b

Added logging to notify user when they do not subscribe to any hubs.

6ff0a85

- Also added logging to show when a client subscribes to a hub. #2514

Added undefined param to JS

52b3a33

#2486

Made logging more consistent throughout the code base.

dfd71d9

- Added periods to the end of every log line. - Removed "SignalR:" from beginning of logged lines so it wasn't logged twice. - Re-worded some language - Added Long poll complete log #2512

Fix Firefox not disconnecting on refresh

6151d1f

- Change the withCredentials flag to only be auto-set when cross-domain is detected (can still be explicitly set) - Conditionally do an async abort if the browser is Firefox 11+ AND withCredentials is true #2489

Make Firefox gracefully abort when a tab is closed

7f97baf

- This change is only needed for cross-domain scenarios - This does not work when the entire browser window is closed #2517

Added ajax defaults that are used to override any default ajax setups…

e3ffaf1

… to prevent our ajax communications from failing. #2511

Added tests to verify the correctness of our ajax default overriding.

a755ba5

#2511

Added retry logic to service bus when creation of subscription/topic …

6aa61b0

…or receiving of messages fails #2585

Made changes to not throw exceptions in case of config, auth or messa…

3a502ac

…ging errors in Service Bus #2542 #2541

Moved opening of the stream to after ProcessMessages

137151a

abnanda1 and others added 28 commits September 24, 2013 13:35

Made some formatting changes

8e4d8aa

#2504

Require the WebSocket Transport make an /abort request to abort

1568fa6

- Avoids timeouts being mistakenly registered as aborts - Unifies abort logic for all transports #2195 #1231 #2500

Made some websocket improvements.

6cff50d

Catch and log errors on send.

8536bc5

Made some more changes to the WebSocketHandler and client websocket.

39212f6

- Prevent double dispose on the client side WebSocketTransport. - Always close the websocket before cancelling the token on the server.

Make all DefaultWebSocketHandler operations noop after it's closed.

08576ef

- Added tests that verify it noops after closing. - Made the WebSocket property internal to ensure it's not used by another other code. #2457

Added some websocket tests.

e8f19e7

Made some websocket fixes.

b9ad1df

- Create a new cts for each websocket created.

Made closed volatile

7ba30b8

ASP.NET does not support async void methods.

500911e

Handle errors thrown by the websocket transport loop.

3236844

Attach server-side WebSocket event handlers before receiving messages

f47dbe6

Don't start the receive loop before OnConnected in OwinWebSocketHandler

ebf7295

Modified the ping server to no longer special case websockets and to …

8fd61a5

…use the connection.url. - Also added a test to verify the fix. #2570

issue #2485: WebSockets on Galaxy S3 Android Stock Browser

cd8aff8

Fixed memory leak for 2413

a42875e

Made changes based on feedback

d4879a3

Removed handling the QuotaExceededException separately since it is al…

7228134

…so a MessagingException

Removed timeout connecting check from server sent events start logic.

01c6413

#2509

Added tests to verify that forever frame does not throw in start/stop…

3983bff

… stress scenarios. #2494

Added a ping interval on the client to ensure that auth tickets do no…

b3e9564

…t expire when there's lack of activity. - This also involved adding a new configuration option 'pingInterval' which can be set via milliseconds in the connection.start #2507

Added tests to verify that pingInterval behaves correctly with differ…

08a7140

…ent configuration options in addition to multiple connection starts and stops. - Also modified the existing tests which called ping interval by also passing in a transport (no longer need to do that). #2507

Captured several long polling timeouts that are then cleared on stop.

14218ee

- Also added two fields to the private data field of a connection object. #2505

Added a test to verify that starting/stopping a connection while reco…

b6f0c70

…nnecting does not result in simultaneous polls attempting to connect. #2125

Addressed code review comments.

73a4f7b

- Added an extra check after long polling error handler trigger to ensure that multiple connections do not occur. #2505

NTaylorMullen closed this Oct 3, 2013

NTaylorMullen deleted the 2505 branch October 3, 2013 22:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

2505 - Clear LP transport timeouts to prevent multiple connections with same CID #2599

2505 - Clear LP transport timeouts to prevent multiple connections with same CID #2599

NTaylorMullen commented Oct 1, 2013

2505 - Clear LP transport timeouts to prevent multiple connections with same CID #2599

2505 - Clear LP transport timeouts to prevent multiple connections with same CID #2599

Conversation

NTaylorMullen commented Oct 1, 2013