Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Recorder/HandlesRecordedMessagesMiddleware.php
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,9 @@ public function handle($message, callable $next)
foreach ($recordedMessages as $recordedMessage) {
$this->messageBus->handle($recordedMessage);
}

if ($this->messageRecorder->recordedMessages()) {
$this->handle($message, $next);
}
}
}
52 changes: 52 additions & 0 deletions tests/Recorder/HandlesRecordedMessagesMiddlewareTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,58 @@ public function it_rethrows_a_caught_exception_but_first_clears_any_recorded_mes
}
}

/**
* @test
*/
public function it_handles_messages_recorded_during_handling()
{
$messages = [$this->dummyMessage(), $this->dummyMessage()];
$messages2 = [$this->dummyMessage(), $this->dummyMessage()];
$messageRecorder = $this->mockMessageRecorder();

// first recorded messages should be fetched
$messageRecorder
->expects($this->at(0))
->method('recordedMessages')
->will($this->returnValue($messages));

// then immediately erased
$messageRecorder
->expects($this->at(1))
->method('eraseMessages');

// it should check if new messages were recorded
$messageRecorder
->expects($this->at(2))
->method('recordedMessages')
->will($this->returnValue($messages2));

// messages recorded during handling should be fetched
$messageRecorder
->expects($this->at(3))
->method('recordedMessages')
->will($this->returnValue($messages2));

// then immediately erased
$messageRecorder
->expects($this->at(4))
->method('eraseMessages');

$actuallyHandledMessages = [];
$messageBus = $this->messageBusSpy($actuallyHandledMessages);
$middleware = new HandlesRecordedMessagesMiddleware(
$messageRecorder,
$messageBus
);

$next = new CallableSpy();

$middleware->handle($this->dummyMessage(), $next);
// $next should be after each iteration
$this->assertSame(2, $next->hasBeenCalled());
$this->assertSame(array_merge($messages, $messages2), $actuallyHandledMessages);
}

/**
* @param array $actuallyHandledMessages
* @return \PHPUnit_Framework_MockObject_MockObject|MessageBus
Expand Down