Skip to content

Conversation

zivy
Copy link
Member

@zivy zivy commented Apr 20, 2023

Removed debugging code, streamlined the remaining code and added type hints and documentation.

@zivy zivy requested review from blowekamp and dave3d April 20, 2023 15:18
Copy link
Member

@blowekamp blowekamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seem more that just documentation/debug related. The testing needs to be improved.

Also this is not the correct approach to logging.

@zivy zivy force-pushed the vtk branch 2 times, most recently from f7ccc0b to fdc60db Compare April 27, 2023 18:37
Removed debugging code, streamlined the remaining code and added type
hints and documentation.
@zivy zivy merged commit 051df27 into SimpleITK:main Apr 27, 2023
@zivy zivy deleted the vtk branch April 27, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants