Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time lapse view should specify current line when possible #20

Closed
tom-seddon opened this issue Feb 4, 2022 · 3 comments · Fixed by #25
Closed

Time lapse view should specify current line when possible #20

tom-seddon opened this issue Feb 4, 2022 · 3 comments · Fixed by #25
Labels
enhancement New feature or request

Comments

@tom-seddon
Copy link

When possible - so, definitely at least when invoked from an editor tab - invoke as p4vc -l LINE FILE. The -l flag opens the time lapse view with the given line highlighted, and also enables line numbers by default.

PR to hopefully follow at some point.

--Tom

@tom-seddon
Copy link
Author

Is it easy to add stuff to the right click menu?
image
Looks like the line numbers column isn't clickable, so that's a shame.

Anyway, maybe this could be at least a partial solution for #11. Though the -l option only works for the first invocation for a given file. (p4vc will re-use the window for subsequent invocations, but the -l option doesn't work.) So not much fun if you want quick history for a bunch of lines.

--Tom

@SimpsonGSD
Copy link
Owner

Oh great, the original aim was to do this but I didn't know the commandline and got side tracked.

@SimpsonGSD
Copy link
Owner

Is it easy to add stuff to the right click menu? image Looks like the line numbers column isn't clickable, so that's a shame.

Anyway, maybe this could be at least a partial solution for #11. Though the -l option only works for the first invocation for a given file. (p4vc will re-use the window for subsequent invocations, but the -l option doesn't work.) So not much fun if you want quick history for a bunch of lines.

--Tom

It should be easy enough to add a right-click if you can find the correct ID, it will most likely start with IDM_VS_CTXT_. You can then add it to the command table (.vsct).

For #11 I was going to use p4 annotate which gets the revision/user/data/CL/etc for each line of the file. I just don't know the best way to integrate into the IDE that isn't intrusive and has zero performance impact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants