Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move compilation to use tsconfig.json files instead of hardcoded command lines #88

Merged
merged 1 commit into from
Jan 12, 2017

Conversation

dgoldstein0
Copy link
Contributor

Currently there's one checked in tsconfig.json and it actually has different settings than what is used to compile it for testing - in that it says to use strictNullChecks which it doesn't actually compile under.

Part of my motivation for this is that I use a vim plugin which understands the tsconfig.json and tries to do some checking based on it, and it gets rather confused when the tsconfig is wrong - so this fixes that problem.

I do realize that these configs aren't ideal, but my thinking was to get the organization right, and then we can sort out bits like strictNullChecks, noImplicitAny, etc. which the code might not currently work with.

@dylans dylans added this to the 2.1.0 milestone Jan 12, 2017
@dylans
Copy link
Contributor

dylans commented Jan 12, 2017

Seems reasonable, and becoming even more important with inheritance of tsconfig files making them far more useful going forward. Thanks!

@dylans dylans merged commit 61b1c9b into SitePen:master Jan 12, 2017
@dgoldstein0 dgoldstein0 deleted the tsconfig_files_for_compilation branch January 12, 2017 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants