Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support --no-update-pr-body as a commit message flag #140

Closed
tal-zaitsev-skydio opened this issue Jan 10, 2024 · 0 comments · Fixed by #153
Closed

Support --no-update-pr-body as a commit message flag #140

tal-zaitsev-skydio opened this issue Jan 10, 2024 · 0 comments · Fixed by #153
Labels
enhancement New feature or request

Comments

@tal-zaitsev-skydio
Copy link

Is your feature request related to a problem? Please describe.
Sometimes, multi-commit PRs require a summary PR description that does not match the first commit's message. This requires manual modification of the PR description, which would get overwritten on the next revup upload, unless the --no-update-pr-body option is provided.

However, sometimes you do want to update PR bodies for other PRs in your stack. This requires you to manually upload the topics that you don't want to update the body for with the flag set, and then upload the rest of the topics without the flag. And even if you only have 1 PR in your stack, it's easy to forget the flag, causing you to erase your custom description accidentally.

Describe the solution you'd like
Add a commit message flag (similar to Topic, Reviewers, etc.) that prevents the PR body from being updated for the given commits that it's set for. This could be something like UpdateBody: false, which would be true by default.

Describe alternatives you've considered
Manual alternatives described in problem statement, but they are not convenient and easy to forget.
@tal-zaitsev-skydio tal-zaitsev-skydio added the enhancement New feature or request label Jan 10, 2024
jerry-skydio added a commit that referenced this issue Mar 12, 2024
@jerry-skydio
upload: Support Update-Pr-Body as a commit tag
2d1ee0b 
This allows you to manually specify one or more prs
as no-update while maintaining the default option for
all other prs. (and vise versa)

Fixes: #140
@jerry-skydio jerry-skydio mentioned this issue Mar 12, 2024
Merged
jerry-skydio added a commit that referenced this issue Mar 12, 2024
@jerry-skydio
upload: Support Update-Pr-Body as a commit tag
9c265d2 
This allows you to manually specify one or more prs
as no-update while maintaining the default option for
all other prs. (and vise versa)

Fixes: #140
neeeee
jerry-skydio added a commit that referenced this issue Mar 12, 2024
@jerry-skydio
upload: Support Update-Pr-Body as a commit tag
ced232d 
This allows you to manually specify one or more prs
as no-update while maintaining the default option for
all other prs. (and vise versa)

Fixes: #140
nefdsfadseeee
fd
jerry-skydio added a commit that referenced this issue Mar 12, 2024
@jerry-skydio
upload: Support Update-Pr-Body as a commit tag
3028de0 
This allows you to manually specify one or more prs
as no-update while maintaining the default option for
all other prs. (and vise versa)

Fixes: #140
jerry-skydio added a commit that referenced this issue Mar 12, 2024
@jerry-skydio
upload: Support Update-Pr-Body as a commit tag
cad0116 
This allows you to manually specify one or more prs
as no-update while maintaining the default option for
all other prs. (and vise versa)

Fixes: #140
jerry-skydio added a commit that referenced this issue Mar 12, 2024
@jerry-skydio
upload: Support Update-Pr-Body as a commit tag
b3c7fdc 
This allows you to manually specify one or more prs
as no-update while maintaining the default option for
all other prs. (and vise versa)

Fixes: #140
jerry-skydio added a commit that referenced this issue Mar 12, 2024
@jerry-skydio
upload: Support Update-Pr-Body as a commit tag
1060912 
This allows you to manually specify one or more prs
as no-update while maintaining the default option for
all other prs. (and vise versa)

Fixes: #140
jerry-skydio added a commit that referenced this issue Mar 12, 2024
@jerry-skydio
upload: Support Update-Pr-Body as a commit tag
8c32d71 
This allows you to manually specify one or more prs
as no-update while maintaining the default option for
all other prs. (and vise versa)

Fixes: #140
jerry-skydio added a commit that referenced this issue Mar 12, 2024
@jerry-skydio
upload: Support Update-Pr-Body as a commit tag
1b5117c 
This allows you to manually specify one or more prs
as no-update while maintaining the default option for
all other prs. (and vise versa)

Fixes: #140
jerry-skydio added a commit that referenced this issue Mar 12, 2024
@jerry-skydio
upload: Support Update-Pr-Body as a commit tag
cee56e9 
This allows you to manually specify one or more prs
as no-update while maintaining the default option for
all other prs. (and vise versa)

Fixes: #140
jerry-skydio added a commit that referenced this issue Mar 12, 2024
@jerry-skydio
upload: Support Update-Pr-Body as a commit tag
d7975e8 
This allows you to manually specify one or more prs
as no-update while maintaining the default option for
all other prs. (and vise versa)

Fixes: #140
jerry-skydio added a commit that referenced this issue Mar 12, 2024
@jerry-skydio
upload: Support Update-Pr-Body as a commit tag
faf29d6 
This allows you to manually specify one or more prs
as no-update while maintaining the default option for
all other prs. (and vise versa)

Fixes: #140
jerry-skydio added a commit that referenced this issue Mar 12, 2024
@jerry-skydio
upload: Support Update-Pr-Body as a commit tag
9f09747 
This allows you to manually specify one or more prs
as no-update while maintaining the default option for
all other prs. (and vise versa)

Fixes: #140
jerry-skydio added a commit that referenced this issue Mar 12, 2024
@jerry-skydio
upload: Support Update-Pr-Body as a commit tag
371ba9b 
This allows you to manually specify one or more prs
as no-update while maintaining the default option for
all other prs. (and vise versa)

Fixes: #140
jerry-skydio added a commit that referenced this issue Mar 12, 2024
@jerry-skydio
upload: Support Update-Pr-Body as a commit tag
09e2637 
This allows you to manually specify one or more prs
as no-update while maintaining the default option for
all other prs. (and vise versa)

Fixes: #140
jerry-skydio added a commit that referenced this issue Mar 12, 2024
@jerry-skydio
upload: Support Update-Pr-Body as a commit tag
99c3681 
This allows you to manually specify one or more prs
as no-update while maintaining the default option for
all other prs. (and vise versa)

Fixes: #140
jerry-skydio added a commit that referenced this issue Mar 13, 2024
@jerry-skydio
upload: Support Update-Pr-Body as a commit tag
660da5c 
This allows you to manually specify one or more prs
as no-update while maintaining the default option for
all other prs. (and vise versa)

Fixes: #140
jerry-skydio added a commit that referenced this issue Mar 13, 2024
@jerry-skydio
upload: Support Update-Pr-Body as a commit tag
1dd80d5 
This allows you to manually specify one or more prs
as no-update while maintaining the default option for
all other prs. (and vise versa)

Fixes: #140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

upload: Support Update-Pr-Body as a commit tag Skydio/revup
1 participant
@tal-zaitsev-skydio