Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upload: Support Update-Pr-Body as a commit tag #153

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

jerry-skydio
Copy link
Collaborator

@jerry-skydio jerry-skydio commented Mar 12, 2024

This allows you to manually specify one or more prs
as no-update while maintaining the default option for
all other prs. (and vise versa)

Fixes: #140

@jerry-skydio
Copy link
Collaborator Author

jerry-skydio commented Mar 12, 2024

Reviews in this chain:
#153 upload: Support Update-Pr-Body as a commit tag
 └#167 upload: Add "branch-format" config option and commit tag

@jerry-skydio
Copy link
Collaborator Author

jerry-skydio commented Mar 12, 2024

# head base diff date summary
0 2d1ee0b8 9ea9f6a8 diff Mar 12 11:35 AM 1 file changed, 16 insertions(+), 1 deletion(-)
1 9c265d20 9ea9f6a8 diff Mar 12 11:36 AM 0 files changed
2 ced232d7 9ea9f6a8 diff Mar 12 11:37 AM 0 files changed
3 2d1ee0b8 9ea9f6a8 diff Mar 12 11:38 AM 0 files changed
4 3028de02 9ea9f6a8 diff Mar 12 11:39 AM 1 file changed, 4 insertions(+), 1 deletion(-)
5 cad01164 f2506f16 rebase Mar 12 13:39 PM 0 files changed
6 b3c7fdc3 df295937 rebase Mar 12 13:52 PM 0 files changed
7 10609123 2c810f31 rebase Mar 12 14:46 PM 0 files changed
8 8c32d713 b8f56cad rebase Mar 12 14:48 PM 0 files changed
9 1b5117ca 06778e61 rebase Mar 12 14:49 PM 0 files changed
10 cee56e9d 57328501 rebase Mar 12 15:04 PM 0 files changed
11 d7975e89 cdfceb11 rebase Mar 12 15:07 PM 0 files changed
12 faf29d6a fd95dd87 rebase Mar 12 15:08 PM 0 files changed
13 9f097479 bc4eeaaf rebase Mar 12 15:16 PM 0 files changed
14 371ba9ba 58d26e76 rebase Mar 12 15:20 PM 0 files changed
15 09e26376 a2975ed8 rebase Mar 12 15:25 PM 0 files changed
16 99c3681a ed750a85 rebase Mar 12 15:27 PM 0 files changed
17 660da5ca b48ebf47 rebase Mar 13 10:58 AM 0 files changed
18 b3c7fdc3 df295937 rebase Mar 13 11:00 AM 0 files changed
19 29f86bf3 65cc1b54 rebase Mar 13 13:29 PM 0 files changed
20 2d6c7c26 f3f012a2 rebase Mar 13 13:40 PM 0 files changed
21 573558fe 1d3dfa14 rebase Mar 13 13:46 PM 0 files changed
22 3a19895f 79d040b3 rebase Mar 13 13:50 PM 0 files changed
23 e370a376 9a5a6e35 rebase Mar 13 14:02 PM 0 files changed
24 8c17f143 4c4b4572 diff Mar 13 14:03 PM 0 files changed
25 98552230 ef12644f rebase Mar 13 14:04 PM 0 files changed
26 c51d4cb3 ef12644f diff Mar 13 14:12 PM 1 file changed, 5 insertions(+), 8 deletions(-)
27 c4ee1e20 ef12644f diff Mar 13 14:14 PM 1 file changed, 3 insertions(+), 1 deletion(-)
28 7ce245cb ef12644f diff Mar 13 14:15 PM 1 file changed, 2 insertions(+), 1 deletion(-)

@jerry-skydio jerry-skydio force-pushed the jerry/revup/main/prbody branch 4 times, most recently from 2d1ee0b to 3028de0 Compare March 12, 2024 18:40
@jerry-skydio jerry-skydio changed the base branch from main to jerry/revup/main/anyorder March 12, 2024 20:40
@jerry-skydio jerry-skydio changed the base branch from jerry/revup/main/anyorder to main March 12, 2024 20:53
@jerry-skydio jerry-skydio changed the base branch from main to jerry/revup/main/anyorder March 12, 2024 21:47
@jerry-skydio jerry-skydio force-pushed the jerry/revup/main/prbody branch 2 times, most recently from 1b5117c to cee56e9 Compare March 12, 2024 22:05
@jerry-skydio jerry-skydio force-pushed the jerry/revup/main/anyorder branch 2 times, most recently from 5732850 to cdfceb1 Compare March 12, 2024 22:08
@jerry-skydio jerry-skydio force-pushed the jerry/revup/main/prbody branch 2 times, most recently from faf29d6 to 9f09747 Compare March 12, 2024 22:17
@jerry-skydio jerry-skydio force-pushed the jerry/revup/main/prbody branch 2 times, most recently from 09e2637 to 99c3681 Compare March 12, 2024 22:28
Copy link
Contributor

@aaron-skydio aaron-skydio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool - might be worth noting for documentation purposes either here or on #140 or somewhere else that another way to do this is with an empty first commit with just the message? At least that's what I usually do, if I'm understanding #140 correctly. I'm sure some people would prefer either way through so no objection to having both methods

@jerry-skydio
Copy link
Collaborator Author

yeah i prefer that too but there's benefits to the github ui if you do a lot of formatting or attachments

@jerry-skydio jerry-skydio changed the base branch from jerry/revup/main/anyorder to main March 13, 2024 18:01
@jerry-skydio jerry-skydio force-pushed the jerry/revup/main/prbody branch 2 times, most recently from b3c7fdc to 29f86bf Compare March 13, 2024 20:30
@jerry-skydio jerry-skydio changed the base branch from main to jerry/revup/main/anyorder March 13, 2024 20:30
@jerry-skydio jerry-skydio force-pushed the jerry/revup/main/prbody branch 2 times, most recently from 2d6c7c2 to 573558f Compare March 13, 2024 20:47
@jerry-skydio jerry-skydio force-pushed the jerry/revup/main/anyorder branch 2 times, most recently from 1d3dfa1 to 79d040b Compare March 13, 2024 20:51
@jerry-skydio jerry-skydio force-pushed the jerry/revup/main/prbody branch 2 times, most recently from 3a19895 to e370a37 Compare March 13, 2024 21:03
This allows you to manually specify one or more prs
as no-update while maintaining the default option for
all other prs. (and vise versa)

Fixes: #140
Base automatically changed from jerry/revup/main/anyorder to main March 13, 2024 21:04
@jerry-skydio jerry-skydio force-pushed the jerry/revup/main/prbody branch 5 times, most recently from c4ee1e2 to 7ce245c Compare March 13, 2024 21:16
@jerry-skydio jerry-skydio merged commit 1dd80d5 into main Mar 13, 2024
4 checks passed
@jerry-skydio jerry-skydio deleted the jerry/revup/main/prbody branch March 13, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support --no-update-pr-body as a commit message flag
3 participants