Skip to content

[ICP-8763] Zigbee Metering Plug: Prevent duplicate switch events #36353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2020
Merged

[ICP-8763] Zigbee Metering Plug: Prevent duplicate switch events #36353

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e991ce
Ignoring duplicated switch events
BJanuszS Jul 7, 2020
d33c902
Double events fixed by ignoring catchall desc
BJanuszS Jul 14, 2020
645b922
Changed condition for ignoring duplicated event
BJanuszS Jul 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions devicetypes/smartthings/zigbee-metering-plug.src/zigbee-metering-plug.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,16 @@ def getATTRIBUTE_HISTORICAL_CONSUMPTION() { 0x0400 }
def parse(String description) {
log.debug "description is $description"
def event = zigbee.getEvent(description)
def descMap = zigbee.parseDescriptionAsMap(description)
def powerDiv = 1
def energyDiv = 100

if (event) {
log.info "event enter:$event"
if (event.name== "power") {
if (event.name == "switch" && !descMap.isClusterSpecific && descMap.commandInt == 0x0B) {
log.info "Ignoring default response with desc map: $descMap"
return [:]
} else if (event.name== "power") {
event.value = event.value/powerDiv
event.unit = "W"
} else if (event.name== "energy") {
Expand All @@ -82,7 +86,6 @@ def parse(String description) {
sendEvent(event)
} else {
List result = []
def descMap = zigbee.parseDescriptionAsMap(description)
log.debug "Desc Map: $descMap"

List attrData = [[clusterInt: descMap.clusterInt ,attrInt: descMap.attrInt, value: descMap.value]]
Expand Down Expand Up @@ -153,4 +156,4 @@ def configure() {
zigbee.onOffConfig() +
zigbee.configureReporting(zigbee.SIMPLE_METERING_CLUSTER, ATTRIBUTE_READING_INFO_SET, DataType.UINT48, 1, 600, 1) +
zigbee.electricMeasurementPowerConfig(1, 600, 1)
}
}