Skip to content

CHAD-5256 Hotfix to update child DNIs of zigbee-multi-switch #38146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 23, 2020
Merged

CHAD-5256 Hotfix to update child DNIs of zigbee-multi-switch #38146

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d1fc551
CHAD-5256 change re-addressing code
greens Jul 22, 2020
64c1053
adds a fix for devices that were migrated while this bug was active.
greens Jul 22, 2020
d8da99f
add code to avoid a bug encountered if installed and updated are call…
greens Jul 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions devicetypes/smartthings/zigbee-multi-switch.src/zigbee-multi-switch.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,9 @@ def updated() {
log.debug "updated()"
updateDataValue("onOff", "catchall")
for (child in childDevices) {
if (!child.deviceNetworkId.startsWith(device.deviceNetworkId)) { //parent DNI has changed after rejoin
child.setDeviceNetworkId("${device.deviceNetworkId}:${getChildEndpoint(child.deviceNetworkId)}")
if (!child.deviceNetworkId.startsWith(device.deviceNetworkId) || //parent DNI has changed after rejoin
!child.deviceNetworkId.split(':')[-1].startsWith('0')) {
child.setDeviceNetworkId("${device.deviceNetworkId}:0${getChildEndpoint(child.deviceNetworkId)}")
}
}
refresh()
Expand Down Expand Up @@ -123,10 +124,12 @@ def parse(String description) {
}

private void createChildDevices() {
def x = getChildCount()
for (i in 2..x) {
addChildDevice("Child Switch Health", "${device.deviceNetworkId}:${i}", device.hubId,
[completedSetup: true, label: "${device.displayName[0..-2]}${i}", isComponent: false])
if (!childDevices) {
def x = getChildCount()
for (i in 2..x) {
addChildDevice("Child Switch Health", "${device.deviceNetworkId}:0${i}", device.hubId,
[completedSetup: true, label: "${device.displayName[0..-2]}${i}", isComponent: false])
}
}
}

Expand Down