CHAD-5315 Update SmartWeather Station Tile DTH #38387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkirker
force-pushed
the
CHAD-5315
branch
2 times, most recently
from
5f893d5 to
e458bd8
Compare
|
I've tested this and this works with existing smartapps (backwards compatibility) and with the mobile client and plugin. I also discovered that when using with a PWS ID (I didn't previously have one to test with, but got one from the community -- thanks!) you can take the geo-coordinates from the PWS and pass them to the APIs and get the rest of the forecast. So, that eliminates the need for "-" for the measurements. I'd like to get this in production next Tuesday, so if it doesn't seem like we can merge it this morning I'll rebase it to staging. |
tpmanley
reviewed
Nov 3, 2020
| def tf = new java.text.SimpleDateFormat("h:mm a") | ||
| tf.setTimeZone(TimeZone.getTimeZone(loc.ianaTimeZone)) | ||
| tf.setTimeZone(TimeZone.getTimeZone(loc?.ianaTimeZone)) | ||
There was a problem hiding this comment.
If loc is null what will this code do? You added the null check but I'm wondering if we need to skip the whole line if loc is null.
tpmanley
approved these changes
Nov 3, 2020
shinasys
pushed a commit
to shinasys/SmartThingsPublic
that referenced
this pull request
Apr 29, 2021
…38387) * CHAD-5315 Update SmartWeather Station Tile DTH * Update capabilities * General logic updates, and better support for PWS forecast and conditions * Update city name logic to account for i18n * Update polling logic -- poll once every 3 hours, `update()` reschedules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update SmartWeather Station Tile to ensure backwards compatibility with SmartApps and compatibility with the new client.