Skip to content

Z-Wave Basic Window Shade fix + Calibration #44034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 18, 2020
Merged

Z-Wave Basic Window Shade fix + Calibration #44034

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dc2c16e
Z-Wave Basic Window Shade fix + Calibration
Aeotec-ccheng Sep 16, 2020
8ccd16a
Fix of requested issues
Aeotec-ccheng Sep 16, 2020
18fe124
Fixed Requested issues
Aeotec-ccheng Sep 17, 2020
089aef1
Update Part 3 - Nano Shutter
Aeotec-ccheng Sep 17, 2020
3b2f208
Update Nano Shutter Part 4
Aeotec-ccheng Sep 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 24 additions & 3 deletions devicetypes/smartthings/zwave-basic-window-shade.src/zwave-basic-window-shade.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,22 @@ metadata {
defaultValue: false,
displayDuringSetup: false
)

//This setting for calibrationTime is specific to Aeotec Nano Shutter and operates under def updated() - Line 159
input("calibrationTime", "number",
title: "Open/Close timing",
description: "Set the motor's open/close time",
defaultValue: false,
displayDuringSetup: false,
range: "5..255",
default: 10
)
}
}
}

def parse(String description) {
log.debug "parse() - description: $description"
def result = []
if (description.startsWith("Err")) {
result = createEvent(descriptionText:description, isStateChange:true)
Expand Down Expand Up @@ -101,11 +112,14 @@ def zwaveEvent(physicalgraph.zwave.Command cmd) {
}

def setButton(button) {
log.debug "button: $button"
switch(button) {
case "open":
case "statelessCurtainPowerButton_open_button":
open()
break
case "close":
case "statelessCurtainPowerButton_close_button":
close()
break
default:
Expand Down Expand Up @@ -147,13 +161,20 @@ def installed() {
def updated() {
sendHubCommand(pause())
state.reverseDirection = reverseDirection ? reverseDirection : false

if (calibrationTime >= 5 && calibrationTime <= 255) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean to be checking time instead of calibrationTime here? As far as I can tell they should be equal, though, so I don't know if having a second variable is worthwhile.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that we should just use calibrationTime here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@greens @cbaumler - the "int time = calibrationTime" was primarily with me messing around and practicing a little bit while figuring out how preferences are used as numbers/integrrs, i ended up leaving it in there and forgot to remove it when i realized calibrationTime was pretty much a local variable for the device handler.

I'll have that removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@greens @cbaumler - edited for this function to only use calibrationTime number.

response([
secure(zwave.configurationV1.configurationSet(parameterNumber: 35, size: 1, scaledConfigurationValue: calibrationTime)),
])
}

}

def configure() {
log.debug "Configure..."
response([
secure(zwave.configurationV1.configurationSet(parameterNumber: 80, size: 1, scaledConfigurationValue: 1)),
secure(zwave.configurationV1.configurationSet(parameterNumber: 85, size: 1, scaledConfigurationValue: 1))
secure(zwave.configurationV1.configurationSet(parameterNumber: 80, size: 1, scaledConfigurationValue: 1)),
secure(zwave.configurationV1.configurationSet(parameterNumber: 85, size: 1, scaledConfigurationValue: 1))
])
}

Expand All @@ -171,4 +192,4 @@ private getOpenValue() {

private getCloseValue() {
!state.reverseDirection ? 0xFF : 0x00
}
}