[WWST-7126] Fingerprint for Somfy Situo 1 #47897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MWierzbinskaS
changed the title
greens
reviewed
Oct 22, 2020
Comment on lines
369
to
370
| private boolean isSomfySituo() { | ||
| device.getDataValue("model") == "Situo 4 Zigbee" | ||
| device.getDataValue("model") == "Situo 4 Zigbee" || device.getDataValue("model") == "Situo 1 Zigbee" |
There was a problem hiding this comment.
Do you want to just refactor this to isSomfy and just check the manufacturer?
There was a problem hiding this comment.
I suppose naming the function isSomfy or leaving as isSomfySituo is fine, as they are both accurate.
greens
reviewed
Oct 22, 2020
| fingerprint manufacturer: "IKEA of Sweden", model: "TRADFRI open/close remote", deviceJoinName: "IKEA Remote Control", mnmn: "SmartThings", vid: "SmartThings-smartthings-IKEA_TRADFRI_open/close_remote" // raw description 01 0104 0203 01 07 0000 0001 0003 0009 0020 1000 FC7C 07 0003 0004 0006 0008 0019 0102 1000 //IKEA TRÅDFRI Open/Close Remote | ||
| fingerprint manufacturer: "KE", model: "TRADFRI open/close remote", deviceJoinName: "IKEA Remote Control", mnmn: "SmartThings", vid: "SmartThings-smartthings-IKEA_TRADFRI_open/close_remote" // raw description 01 0104 0203 01 07 0000 0001 0003 0009 0020 1000 FC7C 07 0003 0004 0006 0008 0019 0102 1000 //IKEA TRÅDFRI Open/Close Remote | ||
| fingerprint manufacturer: "SOMFY", model: "Situo 4 Zigbee", deviceJoinName: "SOMFY Remote Control", mnmn: "SmartThings", vid: "SmartThings-smartthings-Somfy_open/close_remote" // raw description 01 0104 0203 00 02 0000 0003 04 0003 0005 0006 0102 | ||
| fingerprint manufacturer: "SOMFY", model: "Situo 1 Zigbee", deviceJoinName: "SOMFY Remote Control", mnmn: "SmartThings", vid: "SmartThings-smartthings-Somfy_open/close_remote" // raw description 01 0104 0203 00 02 0000 0003 04 0003 0005 0006 0102 |
There was a problem hiding this comment.
what's the difference between 4 and 1? Is there any?
There was a problem hiding this comment.
Those are very similar devices. I think that here you can find good explanation about differences https://www.screeninnovations.com/accessories/situo-remote-4-ch/
dkirker
approved these changes
Oct 26, 2020
greens
approved these changes
Oct 26, 2020
shinasys
pushed a commit
to shinasys/SmartThingsPublic
that referenced
this pull request
Apr 29, 2021
* [WWST7126] Fingerprint for Somfy Situo 1 * shortened checking if is somfy situo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@SmartThingsCommunity/srpol-pe-team
@greens could you please take a look at the code?