feat: make client factory customizable #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow developers to use Smartling's internal client factory for system tests, etc.
foo4u
requested review from
AlexArcher,
bloy-smartling and
vlinetskiysml
as code owners
| public abstract class AbstractApiFactory<T> implements ApiFactory<T> | ||
| { | ||
| static ClientFactory defaultClientFactory() |
There was a problem hiding this comment.
so its in public class we try to load internal implementation first... seems unusual, but I guess its the best we can do here, right?
There was a problem hiding this comment.
Ok, let's use the other approach we discussed with making sure all API factories export both constructors. Will update PR, thanks!
foo4u
requested review from
andreyfurdylo,
borys-lukianov,
dimitrystd,
dkBrazz,
ishulyak-smartling,
iskrypka-smartling and
PavloMyrotiuk
as code owners
foo4u
changed the title
vlinetskiysml
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow developers to provide a custom client factory implementation.
JIRA Ticket