fix: Array parameters for localeIdsToAuthorize[] in FilesApi #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s expected by the service. Our custom multipart writer moved into a separate package.
dkBrazz
requested review from
AlexArcher,
bloy-smartling,
borys-lukianov,
dimitrystd,
foo4u,
iskrypka-smartling and
vlinetskiysml
as code owners
smartling-api-commons/src/main/java/com/smartling/resteasy/ext/ExtendedMultipartFormWriter.java
Outdated
Show resolved
Hide resolved
foo4u
reviewed
Dec 17, 2019
| */ | ||
| @Provider | ||
| @Produces("multipart/form-data") | ||
| public class ExtendedMultipartFormWriter extends MultipartFormAnnotationWriter |
There was a problem hiding this comment.
This class is missing unit test coverage.
dimitrystd
approved these changes
Dec 17, 2019
AlexArcher
approved these changes
Dec 18, 2019
iskrypka-smartling
approved these changes
Dec 25, 2019
Upgrade to the latest 3.x.x RestEasy (our code isn't compatible with 4.x.x)
foo4u
approved these changes
Jun 9, 2020
sl-mmuradov
approved these changes
Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Array parameter localeIdsToAuthorize[] in FilesApi didn't work as expected by the service. Our custom multipart writer moved into a separate package.