feat: add deleteContextsAsync and getAsyncProcess endpoints (delta-1534) #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MihailTymoshenko
requested review from
AlexArcher,
bloy-smartling and
foo4u
as code owners
MihailTymoshenko
force-pushed
the
delta-1534-add-delete-contexts-and-get-async-process-endpoints
branch
5 times, most recently
from
0198346 to
3b5e631
Compare
vbarhatov
approved these changes
Nov 25, 2021
|
|
||
| @Data | ||
| @JsonInclude(JsonInclude.Include.NON_NULL) | ||
| public class MatchAsyncProcessResultPTO implements AsyncProcessResultPTO |
There was a problem hiding this comment.
in deserialising of response
| @GET | ||
| @Path("/projects/{projectId}/match/{matchId}") | ||
| @Deprecated | ||
| MatchStatusPTO matchAsyncStatus(@PathParam("projectId") String projectId, @PathParam("matchId") String matchId); |
There was a problem hiding this comment.
We discussed with Mikhail how to get rid of this method and replace.
vbarhatov
requested changes
Nov 30, 2021
| private String createdDate; | ||
| private String modifiedDate; | ||
| @JsonDeserialize(contentAs = MatchAsyncProcessResultPTO.class) | ||
| private AsyncProcessResultPTO result; |
There was a problem hiding this comment.
It's better to use Optional for this and errorMessage fields
There was a problem hiding this comment.
In case if we use Optional for other endpoints))
There was a problem hiding this comment.
Optional is not used in our endpoints and whole sdk
| public class AsyncProcessPTO implements ResponseData | ||
| { | ||
| private String processUid; | ||
| private AsyncProcessState state; |
There was a problem hiding this comment.
I've changed these parameters to processState and processType
| assertTrue(request.getPath().contains("/projects/" + PROJECT_UID + "/match/" + MATCH_ID)); | ||
| } | ||
| assertTrue(request.getPath().contains("/projects/" + PROJECT_UID + "/processes/" + PROCESS_UID)); | ||
| } |
MihailTymoshenko
force-pushed
the
delta-1534-add-delete-contexts-and-get-async-process-endpoints
branch
from
3b5e631 to
181aff8
Compare
vbarhatov
approved these changes
Dec 1, 2021
MihailTymoshenko
deleted the
delta-1534-add-delete-contexts-and-get-async-process-endpoints
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket