-
Notifications
You must be signed in to change notification settings - Fork 168
MCP client support for streamable HTTP #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added support for streamable http transport
Caution Review failedThe pull request is closed. WalkthroughIntroduces v1.5.50 in core with changelog and package.json version bump. Refactors MCPClient to add a private connectMCP helper that first attempts Streamable HTTP transport, analyzes errors, and falls back to SSE transport when unsupported. Updates process flow to use the new connection method and adds logging. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Caller as Caller
participant MCP as MCPClient
participant Conn as connectMCP()
participant SHTTP as StreamableHTTPClientTransport
participant SSE as SSEClientTransport
Caller->>MCP: process(mcpUrl)
MCP->>Conn: connectMCP(mcpUrl)
rect rgba(200,240,255,0.3)
note over Conn,SHTTP: First attempt: Streamable HTTP
Conn->>SHTTP: create/connect(mcpUrl)
alt Streamable connected
SHTTP-->>Conn: client
Conn-->>MCP: { client, transport: "streamable" }
else Error
alt Accept header issue (406/Not Acceptable)
Conn-->>MCP: throw explicit Accept header error
else Unsupported for Streamable (404/405/ENOTFOUND/ECONNREFUSED/CORS)
note over Conn,SSE: Fallback to SSE
Conn->>SSE: create/connect(mcpUrl)
SSE-->>Conn: client
Conn-->>MCP: { client, transport: "sse" }
else Other error
Conn-->>MCP: rethrow original error
end
end
end
MCP-->>Caller: Proceed with connected client
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge Base: Disabled due to data retention organization setting 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (3)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Summary by CodeRabbit