MatchExact and MatchContains now not mandatory #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettmillerb
added a commit
to brettmillerb/servicenow-powershell
that referenced
this pull request
Mar 16, 2019
# This is the 1st commit message: Updated manifest # This is the commit message Snow-Shell#2: Updated Auth Configuration to Support OAuth - Updated Set-ServicewNowAuth to allow OAuth Connection - Added Changed Set-ServiceNowAuthToken to Get-ServiceNowOAuthToken - Made Get-ServiceNowOAuthToken a private function # This is the commit message Snow-Shell#3: Added functional for conditional auth retrieval # This is the commit message Snow-Shell#4: Adjusted to use consistent var declaration avoiding breaking changes # This is the commit message Snow-Shell#5: Removed functions to keep PR clean # This is the commit message Snow-Shell#6: Making OAuth Work with Get-ServiceNowIncident - Changed Paramsets to be non-mandatory and have default values - Updated Default ParameterSet value in Cmdletbinding - Changed detection of params to use $pscmdlet instead of checking vars - various other tweaks to get this working Not able to validate with credential object as getting a 401 error Need to check permissions so I can make sure I don't break anything. Removed launch.json # This is the commit message Snow-Shell#7: Numerous changes to allow for OAuth & Credentials - Added local build for quick testing - Removed `[ValidateNotNullOrEmpty()]` from Mandatory Params as this isn't allowed to be Null or Empty by design - Added check for credentials (Needs tidied up) - Credentials can be explicitly passed to each function call - `Set-ServiceNowAuth` allows for creds or accessToken - Made `$ServiceNowUrl` non-mandatory. # This is the commit message Snow-Shell#8: Removed unnecessary AuthConfig and fixed manifest # This is the commit message Snow-Shell#9: Removed Verbose from OAuth function # This is the commit message Snow-Shell#10: Private functions for OAuth # This is the commit message Snow-Shell#11: Updated functions to allow for OAuth method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is it your intention to be able to use MatchExact and MatchContains in the same query?
Maybe a better approach than what I suggest in this PR would actually be to have MatchExact and MatchContains in seperate parametersets and keep them mandatory?