Add support for V1 mapping #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcomnes
commented
Dec 13, 2022
voxpelli
reviewed
Dec 13, 2022
Add a v1 definition and transformation step Update index.js Co-authored-by: Pelle Wessman <pelle@kodfabrik.se> Signed-off-by: Bret Comnes <166301+bcomnes@users.noreply.github.com> Remove beta field Update index.js Co-authored-by: Pelle Wessman <pelle@kodfabrik.se> Signed-off-by: Bret Comnes <166301+bcomnes@users.noreply.github.com> Update index.js Co-authored-by: Pelle Wessman <pelle@kodfabrik.se> Signed-off-by: Bret Comnes <166301+bcomnes@users.noreply.github.com> Update test/parse.spec.js Co-authored-by: Pelle Wessman <pelle@kodfabrik.se> Signed-off-by: Bret Comnes <166301+bcomnes@users.noreply.github.com> Feedback Options
|
I think I addressed the changes. If you want to just modify stuff for style or organization feel free to make commits. The suggestion feature doesn't scale too well after a certain level of complexity. |
voxpelli
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.