-
Notifications
You must be signed in to change notification settings - Fork 8
refactor: adderss <-> bytes32 #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ght have 32 bytes address on non-evm chains
…ployDment scripts
7003cd1
to
db1038a
Compare
arthcp
approved these changes
Jul 3, 2025
ameeshaagrawal
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary of conversions
toBytes32
• AppGatewayBase.sol: setAddress, callback of deploy
• DeployForwarder.sol: appg address in deployContract
• Forwarder.sol: getOnChainAddress, old address compatibility (temporary)
• Configurations.sol: appg in verifyConnections — appg can be in address format in plugConfig; watcher-processor should convert it when setting
• Socket.sol: sb in payloadId creation
• Socket.sol: plug, sb in triggerEvent
• SocketUtils.sol: socket, target in digest creation
• WritePrecompile: appg in digest creation
toAddress
• Trigger.sol: appg address — can be handled in watcher-processor
📝 Notes
• Configurations.sol and Trigger.sol can be updated, but there’s no immediate need for action.
• Let’s merge and add comments to revisit these later.